establish_channel_with_system by xlc · Pull Request #3721 · paritytech/polkadot-sdk

xlc · 2024-03-17T09:48:43Z

Implements polkadot-fellows/RFCs#82
Allow any parachain to have bidirectional channel with any system parachains

Looking for initial feedbacks before continue finish it

TODOs:

docs
benchmarks
tests

polkadot/runtime/parachains/src/hrmp.rs

joepetrowski

I think the approach is OK, just a few naming comments.

joepetrowski · 2024-03-25T05:17:58Z

polkadot/runtime/parachains/src/hrmp.rs

+		/// The default channel size and capacity to use when opening a channel to a system
+		/// parachain.
+		type DefaultChannelSizeAndCapacityToSystem: Get<(u32, u32)>;


I would add an integrity_test that these are below the maximum allowed by Configuration.

config is from storages so it is not really possible to assert it at build time.
if the value is above the max defined in config, the call will fail, and I think that's fine.

Ah right 👍

We do run integrity_test in externalities, so at least the genesis values can be checked.

but why check with genesis values?

Because they should also be correct? but its not a must, just an idea.

polkadot/runtime/parachains/src/hrmp.rs

acatangiu

approach looks good, will approve once PR is final (todos, tests, benchmarks, etc)

kianenigma

LGTM

polkadot/runtime/parachains/src/hrmp.rs

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

paritytech-cicd-pr · 2024-03-26T07:01:23Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5654892

xlc · 2024-03-27T04:32:50Z

polkadot/runtime/rococo/src/weights/runtime_parachains_hrmp.rs

+		//  Measured:  `417`
+		//  Estimated: `6357`
+		// Minimum execution time: 629_674_000 picoseconds.
+		Weight::from_parts(640_174_000, 0)


copied from establish_system_channel

polkadot/runtime/parachains/src/hrmp.rs

xlc · 2024-04-03T02:32:56Z

not sure why PRDoc check failed?

acatangiu · 2024-04-03T08:28:31Z

not sure why PRDoc check failed?

You need to specify what kind of bump should the affected crates get:

polkadot-sdk/prdoc/pr_3927.prdoc

Line 13 in 665e365

bump: minor

polkadot/runtime/westend/src/lib.rs

prdoc/pr_3721.prdoc

Co-authored-by: Adrian Catangiu <adrian@parity.io>

substrate/frame/support/src/traits/randomness.rs

polkadot/runtime/parachains/src/hrmp/benchmarking.rs

Implements polkadot-fellows/RFCs#82 Allow any parachain to have bidirectional channel with any system parachains Looking for initial feedbacks before continue finish it TODOs: - [x] docs - [x] benchmarks - [x] tests --------- Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: Adrian Catangiu <adrian@parity.io>

Allows any parachain to have bidirectional channel with any system parachains. Relates to: polkadot-fellows/RFCs#82 Relates to: paritytech/polkadot-sdk#3721 Relates to: paritytech/polkadot-sdk#4332   - [x] regenerate weights for `runtime_parachains::hrmp` - [ ] Does not require a CHANGELOG entry ## Polkadot weights (the threshold moved from the default 5 to 0.1 to see some differences) ``` subweight compare commits --path-pattern "./relay/polkadot/**/weights/**/*.rs" --format markdown --no-color --change added changed --method asymptotic --ignore-errors --threshold 0.1 remotes/polkadot-fellows/main origin/bko-hrmp-patch ``` | File | Extrinsic | Old | New | Change [%] | |-------------------------------------------------------|-------------------------------|----------|----------|------------| | relay/polkadot/src/weights/runtime_parachains_hrmp.rs | poke_channel_deposits | 137.20us | 140.03us | +2.06 | | relay/polkadot/src/weights/runtime_parachains_hrmp.rs | hrmp_accept_open_channel | 555.89us | 563.03us | +1.28 | | relay/polkadot/src/weights/runtime_parachains_hrmp.rs | hrmp_close_channel | 556.97us | 563.79us | +1.22 | | relay/polkadot/src/weights/runtime_parachains_hrmp.rs | hrmp_init_open_channel | 732.03us | 740.10us | +1.10 | | relay/polkadot/src/weights/runtime_parachains_hrmp.rs | force_open_hrmp_channel | 1.16ms | 1.17ms | +0.98 | | relay/polkadot/src/weights/runtime_parachains_hrmp.rs | establish_system_channel | 1.15ms | 1.16ms | +0.69 | | relay/polkadot/src/weights/runtime_parachains_hrmp.rs | force_process_hrmp_open | 102.05ms | 102.47ms | +0.42 | | relay/polkadot/src/weights/runtime_parachains_hrmp.rs | force_clean_hrmp | 91.52ms | 91.86ms | +0.37 | | relay/polkadot/src/weights/runtime_parachains_hrmp.rs | clean_open_channel_requests | 16.56ms | 16.61ms | +0.35 | | relay/polkadot/src/weights/runtime_parachains_hrmp.rs | force_process_hrmp_close | 75.41ms | 75.65ms | +0.33 | | relay/polkadot/src/weights/runtime_parachains_hrmp.rs | hrmp_cancel_open_request | 422.12us | 415.03us | -1.68 | | relay/polkadot/src/weights/runtime_parachains_hrmp.rs | establish_channel_with_system | | 1.67ms | Added | ## Kusama weights (the threshold moved from the default 5 to 0.1 to see some differences) ``` subweight compare commits --path-pattern "./relay/kusama/**/weights/**/*.rs" --format markdown --no-color --change added changed --method asymptotic --ignore-errors --threshold 0.1 remotes/polkadot-fellows/main origin/bko-hrmp-patch ``` | File | Extrinsic | Old | New | Change [%] | |-----------------------------------------------------|-------------------------------|----------|----------|------------| | relay/kusama/src/weights/runtime_parachains_hrmp.rs | poke_channel_deposits | 137.23us | 140.25us | +2.20 | | relay/kusama/src/weights/runtime_parachains_hrmp.rs | hrmp_close_channel | 557.39us | 564.18us | +1.22 | | relay/kusama/src/weights/runtime_parachains_hrmp.rs | hrmp_accept_open_channel | 556.49us | 563.23us | +1.21 | | relay/kusama/src/weights/runtime_parachains_hrmp.rs | hrmp_init_open_channel | 735.26us | 743.59us | +1.13 | | relay/kusama/src/weights/runtime_parachains_hrmp.rs | force_open_hrmp_channel | 1.16ms | 1.17ms | +0.97 | | relay/kusama/src/weights/runtime_parachains_hrmp.rs | establish_system_channel | 1.15ms | 1.16ms | +0.84 | | relay/kusama/src/weights/runtime_parachains_hrmp.rs | hrmp_cancel_open_request | 413.79us | 416.03us | +0.54 | | relay/kusama/src/weights/runtime_parachains_hrmp.rs | force_process_hrmp_open | 101.96ms | 102.43ms | +0.46 | | relay/kusama/src/weights/runtime_parachains_hrmp.rs | clean_open_channel_requests | 16.54ms | 16.61ms | +0.45 | | relay/kusama/src/weights/runtime_parachains_hrmp.rs | force_clean_hrmp | 91.43ms | 91.82ms | +0.43 | | relay/kusama/src/weights/runtime_parachains_hrmp.rs | force_process_hrmp_close | 75.34ms | 75.63ms | +0.40 | | relay/kusama/src/weights/runtime_parachains_hrmp.rs | establish_channel_with_system | | 1.67ms | Added |

xlc added 3 commits March 17, 2024 22:47

establish_channel_with_system

466d0ab

Merge branch 'master' into hrml_with_system

eb7c039

fmt

544e787

ggwpez reviewed Mar 17, 2024

View reviewed changes

polkadot/runtime/parachains/src/hrmp.rs Outdated Show resolved Hide resolved

joepetrowski reviewed Mar 23, 2024

View reviewed changes

polkadot/runtime/parachains/src/hrmp.rs Outdated Show resolved Hide resolved

polkadot/runtime/parachains/src/hrmp.rs Outdated Show resolved Hide resolved

xlc added 3 commits March 25, 2024 14:25

make default channel para to be configuable

1f80342

fmt

30560d2

fix

1e3b210

joepetrowski reviewed Mar 25, 2024

View reviewed changes

acatangiu reviewed Mar 25, 2024

View reviewed changes

kianenigma reviewed Mar 25, 2024

View reviewed changes

ggwpez reviewed Mar 25, 2024

View reviewed changes

polkadot/runtime/parachains/src/hrmp.rs Outdated Show resolved Hide resolved

xlc and others added 6 commits March 26, 2024 18:08

Update polkadot/runtime/parachains/src/hrmp.rs

cf94655

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

Update polkadot/runtime/parachains/src/hrmp.rs

b6bc275

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

rename and event

79da662

fmt

1a1df49

Merge branch 'master' into hrml_with_system

4cd357c

semi

7ed9f54

xlc added 3 commits March 26, 2024 20:01

fix

e163fa8

add benchmarks and docs

807d088

Merge branch 'master' into hrml_with_system

af7edef

xlc commented Mar 27, 2024

View reviewed changes

xlc added 2 commits March 27, 2024 20:05

fix

af1f337

fix

debdef6

joepetrowski added T6-XCM This PR/Issue is related to XCM. T14-system_parachains This PR/Issue is related to system parachains. labels Mar 27, 2024

xlc added 2 commits March 27, 2024 21:27

tests

2439a77

prdoc

f68454a

ggwpez approved these changes Mar 27, 2024

View reviewed changes

polkadot/runtime/parachains/src/hrmp.rs Show resolved Hide resolved

acatangiu approved these changes Apr 3, 2024

View reviewed changes

polkadot/runtime/westend/src/lib.rs Show resolved Hide resolved

acatangiu reviewed Apr 3, 2024

View reviewed changes

prdoc/pr_3721.prdoc Outdated Show resolved Hide resolved

xlc and others added 4 commits April 3, 2024 22:00

Update prdoc/pr_3721.prdoc

35db15a

Co-authored-by: Adrian Catangiu <adrian@parity.io>

Merge branch 'master' into hrml_with_system

01752a9

Merge branch 'master' into hrml_with_system

4e4844c

remove debug print

59f8cc2

xlc requested a review from a team as a code owner April 12, 2024 05:22

joepetrowski approved these changes Apr 12, 2024

View reviewed changes

Apply suggestions from code review

c92d726

joepetrowski enabled auto-merge April 12, 2024 05:40

joepetrowski added this pull request to the merge queue Apr 12, 2024

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 12, 2024

acatangiu added this pull request to the merge queue Apr 12, 2024

Merged via the queue into paritytech:master with commit b1db5f3 Apr 12, 2024

xlc deleted the hrml_with_system branch April 14, 2024 01:57

xlc mentioned this pull request Apr 14, 2024

Permisionless way to create HRMP channels between system parachains and other parachains polkadot-fellows/RFCs#82

Closed

This was referenced May 27, 2024

Make sure we backported and released all relevant patches from 1.7.0 untill 1.11.0 paritytech/parity-bridges-common#2994

Closed

Add establish_channel_with_system to the HRMP pallet polkadot-fellows/runtimes#329

Merged

Roznovjak mentioned this pull request Sep 2, 2024

chore: upgrade to polkadot v1.11.0 galacticcouncil/Basilisk-node#666

Merged

Roznovjak mentioned this pull request Sep 13, 2024

chore: upgrade to polkadot v1.11.0 galacticcouncil/hydration-node#889

Merged

TDemeco mentioned this pull request Sep 30, 2024

feat: ⏫ upgrade to Polkadot SDK v1.11.0 Moonsong-Labs/storage-hub#212

Merged

Conversation

xlc commented Mar 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joepetrowski left a comment

Choose a reason for hiding this comment

Uh oh!

joepetrowski Mar 25, 2024

Choose a reason for hiding this comment

Uh oh!

xlc Mar 27, 2024

Choose a reason for hiding this comment

Uh oh!

joepetrowski Mar 27, 2024

Choose a reason for hiding this comment

Uh oh!

ggwpez Mar 27, 2024

Choose a reason for hiding this comment

Uh oh!

xlc Mar 28, 2024

Choose a reason for hiding this comment

Uh oh!

ggwpez Mar 28, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

acatangiu left a comment

Choose a reason for hiding this comment

Uh oh!

kianenigma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

paritytech-cicd-pr commented Mar 26, 2024

Uh oh!

xlc Mar 27, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xlc commented Apr 3, 2024

Uh oh!

acatangiu commented Apr 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

xlc commented Mar 17, 2024 •

edited

Loading